Skip to content

Commit

Permalink
fix(report): waiting promise resolve in onExist method fix karma-runn…
Browse files Browse the repository at this point in the history
…er#418

onComplete are async method which should bw complete in onExit method
  • Loading branch information
anthony-redFox committed Jul 22, 2020
1 parent 32acafa commit 9bc1103
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 4 deletions.
9 changes: 7 additions & 2 deletions lib/reporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,13 @@ var CoverageReporter = function (rootConfig, helper, logger, emitter) {
coverageMap.merge(result.coverage)
}

const promiseCollection = []

this.onRunComplete = async function (browsers, results) {
const checkedCoverage = {}

for (const reporterConfig of reporters) {
await Promise.all(browsers.map(async (browser) => {
const promise = Promise.all(browsers.map(async (browser) => {
const coverageMap = coverageMaps[browser.id]
if (!coverageMap) {
return
Expand Down Expand Up @@ -266,10 +268,13 @@ var CoverageReporter = function (rootConfig, helper, logger, emitter) {
report.execute(context)
})
}))
promiseCollection.push(promise)
await promise
}
}

this.onExit = function (done) {
this.onExit = async function (done) {
await Promise.all(promiseCollection)
if (typeof config._onExit === 'function') {
config._onExit(done)
} else {
Expand Down
18 changes: 16 additions & 2 deletions test/reporter.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,9 @@ describe('reporter', () => {
mkdirIfNotExistsStub.resetHistory()
})

it('has no pending file writings', () => {
it('has no pending file writings', async () => {
const done = sinon.spy()
reporter.onExit(done)
await reporter.onExit(done)
expect(done).to.have.been.called
})

Expand Down Expand Up @@ -298,6 +298,20 @@ describe('reporter', () => {
expect(mkdirIfNotExistsStub).not.to.have.been.called
})

it('should calls done callback when onComplete event will be complete', async () => {
reporter = new m.CoverageReporter(rootConfig, mockHelper, mockLogger)
reporter.onRunStart()
browsers.forEach(b => reporter.onBrowserStart(b))
reporter.onRunComplete(browsers)
const done = sinon.stub()

const promiseExit = reporter.onExit(done)

expect(done.notCalled).to.be.true
await promiseExit
expect(done.calledOnce).to.be.true
})

it('should create directory if reporting text* to file', async () => {
const run = () => {
reporter = new m.CoverageReporter(rootConfig, mockHelper, mockLogger)
Expand Down

0 comments on commit 9bc1103

Please sign in to comment.