-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ANTLRInputStream and ANTLRFileStream #3113
Merged
Merged
Commits on Jan 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e24f97d - Browse repository at this point
Copy the full SHA e24f97dView commit details
Commits on Feb 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8391136 - Browse repository at this point
Copy the full SHA 8391136View commit details
Commits on Mar 9, 2021
-
Fixed ANTLRInputStream and ANTLRFileStream
A previous change to add std::string_view support to ANTLRInputStream for C++17 caused some trouble because of ABI changes. This has been changed to define 2 constructors, one for std::string_view (for C++17) and the original one for std::string. This is turn caused an error in ANTLRFileStream, which also takes a string in the constructor (but handling it as file name instead of input). To make this clearer the c-tor taking a std::string has been deleted in ANTLRFileStream and the class now requires to load input via the loadFile() function. This might cause some trouble for those users who had used the std::string constructor of ANTLRFileStream, but I think the better error reporting outweighs the little annoyance.
Configuration menu - View commit details
-
Copy full SHA for 62a829f - Browse repository at this point
Copy the full SHA 62a829fView commit details -
Configuration menu - View commit details
-
Copy full SHA for faa64fd - Browse repository at this point
Copy the full SHA faa64fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93c0621 - Browse repository at this point
Copy the full SHA 93c0621View commit details -
Configuration menu - View commit details
-
Copy full SHA for f881e3e - Browse repository at this point
Copy the full SHA f881e3eView commit details
Commits on Mar 10, 2021
-
More changes to the ANTLRInputStream and ANTLRFileStream classes
- Added a default c-tor to the input stream to avoid an ambiquity. - Changed the input stream API so that it can take a string pointer + length and use that for UTF conversion, avoiding so unnecessary copies. Convenience methods exist to use a std::string or a std::string_view. - With that only a single load() method is necessary. - In ANTLRFileStream the other c-tors are now also deleted, as they make no sense there.
Configuration menu - View commit details
-
Copy full SHA for 84d4ce7 - Browse repository at this point
Copy the full SHA 84d4ce7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5731e64 - Browse repository at this point
Copy the full SHA 5731e64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d1737f - Browse repository at this point
Copy the full SHA 9d1737fView commit details -
C++ is not <any other language where you don't need a useless constructor>
Configuration menu - View commit details
-
Copy full SHA for ff629d5 - Browse repository at this point
Copy the full SHA ff629d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4431f1f - Browse repository at this point
Copy the full SHA 4431f1fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.