name 'state' conflict with Python3 runtime.

[cyqw]

This PR fixes #4291

This change add keyword tests.
add function names in parser as reserved keywords for targets.
use rule.escapedName instead rule.name in php.stg

[ericvergnaud]

Hi,
thanks for this.
Unfortunately it's very likely that some developers are relying on ctx.state (a typical usage scenario is code completion).
The proposed refactoring would break their code. Plus it doesn't solve the problem, rather it moves it (now I can't use _state as a rule name).
I'm afraid the only reasonable solution here is to disallow usage of state as a rule name...

[KvanTTT]

This fix is incorrect. Please add state to Python3 and Python2 reservedWords list without touching runtime files.

Also, it looks like state should be added to JavaScript, TypeScript and Dart reservedWords because CI tests are red: https://github.com/antlr/antlr4/actions/runs/5261330620/jobs/9509322855?pr=4312

[cyqw]

I think add the name of function or attribute of Parser, lexer to reservedWords is not a good idea.
The functions or attributes of parser, lexer should not expose to generated parser, lexer directly by inherit except some functions can be override.
The parser should be split, one is the interface of generated parser, other one is the implement of basic parser, it is a member of generated parser.

[cyqw]

This fix is incorrect. Please add state to Python3 and Python2 reservedWords list without touching runtime files.

Also, it looks like state should be added to JavaScript, TypeScript and Dart reservedWords because CI tests are red: https://github.com/antlr/antlr4/actions/runs/5261330620/jobs/9509322855?pr=4312

@KvanTTT @ericvergnaud please review the new changes, thanks

[KvanTTT]

Sorry, I don't review MR in this repository since I don't have maintainer rights and I can't merge requests. I'm not sure my effort is worth since it's unclear whether a request will be merged or not.

[ericvergnaud]

@parrt blessed

[ericvergnaud]

@parrt kind reminder