Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Renaming lexer grammars (Issue #433) #579

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kjarrio
Copy link
Contributor

@kjarrio kjarrio commented Aug 9, 2022

Signed-off-by: Kjartan Olason olasonk@gmail.com

@@ -1,5 +1,23 @@

Signed-off-by: Kjartan Olason <olasonk@gmail.com>
@kjarrio
Copy link
Contributor Author

kjarrio commented Aug 9, 2022

Please wait before merging this one, I need to test this feature a little bit better, just a couple of edge cases. Thanks.

@parrt
Copy link
Member

parrt commented Aug 13, 2022

Seems like a big change, which makes me nervous as I don't have too much time to think about this project at moment ;)

@kjarrio
Copy link
Contributor Author

kjarrio commented Aug 13, 2022

Yes, although I haven't seen any issue with this while using it this week I think we should let this wait for now

@kjarrio
Copy link
Contributor Author

kjarrio commented Aug 13, 2022

btw, I have a couple of more features in the pipeline, one is larger and the other is smaller, but both are quite useful:

  1. Language injection for Java - working, but still need to finish a couple of more tests. (Issue Inject target language in @header and @members #377)
  2. Context aware Completion - almost ready (Context-aware code completion #367 and Add support to autocomplete tokens defined in an external lexical grammar #284)

I will make PR for those soon, but both are big changes.

@parrt
Copy link
Member

parrt commented Aug 14, 2022

OK well let's be careful about what we had; also remember I don't have a huge amount of time and the plug-in so big changes will likely sit for a long time.

@kjarrio
Copy link
Contributor Author

kjarrio commented Aug 14, 2022

Sure! Most of these changes I use for editing my own grammars, but will make those changes available as a PR though, for the community. No worries whether they get merged or not, now or later, they'll be here if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants