Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Write Payday 2 Effects - Fixes #2133 & #1160 #2134

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

stuntguy3000
Copy link
Contributor

@stuntguy3000 stuntguy3000 commented Jul 11, 2020

List any issues that this PR fixes: Fixes #2133 & #1160

This pull request proposes the following changes (with NO client GSI update required):

  • Remove custom layer effects from defaults
  • Add new layer effects
  • Add new game-responsive effects
  • Update instructions and mod download links
  • Remove broken preview function

Known issues/To do:
N/A

@diogotr7
Copy link
Collaborator

I'm not sure removing layer sis a good idea. Removing them would break everyones profiles. Changing the default to a regular layer with overrides would make sense though.

@stuntguy3000

This comment has been minimized.

@stuntguy3000 stuntguy3000 marked this pull request as draft September 4, 2020 14:31
@stuntguy3000
Copy link
Contributor Author

I'm not sure removing layer sis a good idea. Removing them would break everyones profiles.

Fair point @diogotr7, I've addressed this above (and the merge conflict). As far as I am concerned, this is good to go.

@stuntguy3000 stuntguy3000 marked this pull request as ready for review September 4, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants