Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jenkins e2e jobs #20

Merged
merged 17 commits into from May 20, 2022
Merged

Add jenkins e2e jobs #20

merged 17 commits into from May 20, 2022

Conversation

hangyan
Copy link
Member

@hangyan hangyan commented May 10, 2022

Signed-off-by: Hang Yan yhang@vmware.com

Signed-off-by: Hang Yan <yhang@vmware.com>
Signed-off-by: Hang Yan <yhang@vmware.com>
Signed-off-by: Hang Yan <yhang@vmware.com>
@hangyan
Copy link
Member Author

hangyan commented May 10, 2022

@edwardbadboy This is the updated PR for e2e jobs settings. A few open questions:

  1. where will the flow-aggregator.yaml hosted in the future? still in antrea repo?

@wsquan171 The flow records still does not match by count. Can you help take a look? you can find the paramater adjust in this PR.

Also, during the test, i found out that the clickhouse-operator-install-bundle.yml is still needed before running the test. Can you add it in the test code ?

@edwardbadboy
Copy link

I think flow-aggregator.yml is still in Antrea repo, so the Jenkins job needs to download it from https://raw.githubusercontent.com/antrea-io/antrea/main/build/yamls/flow-aggregator.yml

ci/jenkins/test-vmc.sh Outdated Show resolved Hide resolved
ci/jenkins/test-vmc.sh Outdated Show resolved Hide resolved
Signed-off-by: Hang Yan <yhang@vmware.com>
Signed-off-by: Hang Yan <yhang@vmware.com>
Signed-off-by: Hang Yan <yhang@vmware.com>
Signed-off-by: Hang Yan <yhang@vmware.com>
Signed-off-by: Hang Yan <yhang@vmware.com>
@hangyan
Copy link
Member Author

hangyan commented May 12, 2022

All updated. Including the various parameter adjust and image pre-load. Please help review again if you are free @edwardbadboy @wsquan171

ci/jenkins/jobs/projects.yaml Outdated Show resolved Hide resolved
ci/cluster-api/vsphere/templates/cluster.yaml Outdated Show resolved Hide resolved
ci/cluster-api/vsphere/templates/cluster.yaml Outdated Show resolved Hide resolved
ci/cluster-api/vsphere/templates/cluster.yaml Outdated Show resolved Hide resolved
ci/cluster-api/vsphere/templates/cluster.yaml Outdated Show resolved Hide resolved
ci/jenkins/jobs/projects.yaml Show resolved Hide resolved
ci/jenkins/test-vmc.sh Outdated Show resolved Hide resolved
ci/jenkins/test-vmc.sh Outdated Show resolved Hide resolved
ci/jenkins/test-vmc.sh Outdated Show resolved Hide resolved
ci/jenkins/test-vmc.sh Outdated Show resolved Hide resolved
Signed-off-by: Hang Yan <yhang@vmware.com>
@hangyan
Copy link
Member Author

hangyan commented May 13, 2022

@edwardbadboy all udpated.

@hangyan
Copy link
Member Author

hangyan commented May 13, 2022

@dreamtalen Does the verify-doc step failed because it checks the relative file path on main branch?

@dreamtalen
Copy link
Contributor

Hi Hang, We have PRs in Antrea suffer this dead link error of relative links too, for example, https://github.com/antrea-io/antrea/runs/6375438174?check_suite_focus=true#step:6:81.
I look at this GitHub action and find that there are discussions related to this issue: gaurav-nelson/github-action-markdown-link-check#127
Looks like it is involved from a newly released version and hasn't been resolved yet.
I think we could ignore these failures for now. cc. @edwardbadboy If you know this issue too.

ci/jenkins/README.md Outdated Show resolved Hide resolved
Signed-off-by: Hang Yan <yhang@vmware.com>
ci/jenkins/README.md Outdated Show resolved Hide resolved
ci/jenkins/README.md Show resolved Hide resolved
ci/jenkins/test-vmc.sh Outdated Show resolved Hide resolved
Copy link

@edwardbadboy edwardbadboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got only minor comments.

Signed-off-by: Hang Yan <yhang@vmware.com>
Signed-off-by: Hang Yan <yhang@vmware.com>
ci/jenkins/README.md Outdated Show resolved Hide resolved
ci/jenkins/README.md Outdated Show resolved Hide resolved
ci/jenkins/README.md Outdated Show resolved Hide resolved
ci/jenkins/test-vmc.sh Outdated Show resolved Hide resolved
Signed-off-by: Hang Yan <yhang@vmware.com>
@hangyan
Copy link
Member Author

hangyan commented May 18, 2022

@edwardbadboy All updated.

Signed-off-by: Hang Yan <yhang@vmware.com>
@hangyan
Copy link
Member Author

hangyan commented May 18, 2022

/theia-test-e2e

1 similar comment
@hangyan
Copy link
Member Author

hangyan commented May 18, 2022

/theia-test-e2e

@hangyan
Copy link
Member Author

hangyan commented May 18, 2022

The webhook are configured and this pr has a success result for jenkins e2e test.

ci/jenkins/test-vmc.sh Outdated Show resolved Hide resolved
RUN_CLEANUP_ONLY=true
shift
;;
--coverage)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hangyan Do you think we can remove all coverage related code from test-vmc.sh? There is no coverage support in Theia for now.

ci/jenkins/test-vmc.sh Outdated Show resolved Hide resolved
Signed-off-by: Hang Yan <yhang@vmware.com>
@hangyan
Copy link
Member Author

hangyan commented May 19, 2022

/theia-test-e2e

@hangyan
Copy link
Member Author

hangyan commented May 19, 2022

@edwardbadboy All updated.

@ziyouw
Copy link
Contributor

ziyouw commented May 19, 2022

This PR was for CI functions. Since Zhengsheng approved it, it can be checked in.

Copy link

@edwardbadboy edwardbadboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late comment. I believe they should be the last round...

"metadata": {
"name": "CLUSTERNAMESPACE",
"labels": {
"antrea-ci": "true"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change antrea-ci to theia-ci.

echo "=== Old namespace ${cluster} has been deleted !!! ==="
done

kubectl get ns -l antrea-ci -o custom-columns=Name:.metadata.name,DATE:.metadata.creationTimestamp --no-headers=true | awk '{cmd="echo $(( $(date +%s) - $(date -d "$2" +%s) ))"; cmd | getline t ; print $1, t}' | awk '$1 !~ "matrix" && $1 !~ "whole-conformance" && $2 > 9000 {print $1}' | while read cluster; do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete line 437-450, and change antrea-ci to theia-ci in this line.

We can also change the awk expression in this line from

awk '$1 !~ "matrix" && $1 !~ "whole-conformance" && $2 > 9000 {print $1}'

to

awk '$2 > 9000 {print $1}'

publishers:
- archive:
allow-empty: true
artifacts: theia-test-logs.tar.gz, e2e-coverage.tar.gz

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove e2e-coverage.tar.gz from artifacts?

Signed-off-by: Hang Yan <yhang@vmware.com>
@hangyan
Copy link
Member Author

hangyan commented May 19, 2022

/theia-test-e2e

Signed-off-by: Hang Yan <yhang@vmware.com>
@hangyan
Copy link
Member Author

hangyan commented May 19, 2022

/theia-test-e2e

@hangyan
Copy link
Member Author

hangyan commented May 19, 2022

@edwardbadboy Updated.

Copy link

@edwardbadboy edwardbadboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's merge the change.

@salv-orlando salv-orlando merged commit a7c4af3 into antrea-io:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants