Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Progress Bar Background Color Issue (#3307) #3313

Conversation

imrushikesh77
Copy link

Modified: src/cards/top-languages-card.js
Changed progress bar background color from #ddd to #222222

 modified:   src/cards/top-languages-card.js
@vercel
Copy link

vercel bot commented Oct 1, 2023

@imrushikesh77 is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the lang-card Issues related to the language card. label Oct 1, 2023
@a-s-t-e-y-a
Copy link

@imrushikesh77 I think the progress bar colour should be provided in the query section so that user defined it's own colour
I already generated a PR regarding this issue
#3312

Copy link
Collaborator

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imrushikesh77 I think the progress bar colour should be provided in the query section so that user defined it's own colour I already generated a PR regarding this issue #3312

@a-s-t-e-y-a You're completely right in your thoughts. I'm closing this in favour of #3312

@qwerty541 qwerty541 closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-card Issues related to the language card.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants