Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix card height Issue #3387

Closed
wants to merge 20 commits into from
Closed

Conversation

airwakz
Copy link

@airwakz airwakz commented Oct 18, 2023

@vercel
Copy link

vercel bot commented Oct 18, 2023

@airwakz is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added documentation Improvements or additions to documentation. stats-card Feature, Enhancement, Fixes related to stats the stats card. repo-card Issues related to the pin/repo card. lang-card Issues related to the language card. labels Oct 18, 2023
@airwakz
Copy link
Author

airwakz commented Oct 18, 2023

@rickstaa can uh please label it as hacktober accepted

@airwakz
Copy link
Author

airwakz commented Oct 18, 2023

Please review this code

@rickstaa
Copy link
Collaborator

You also included your changes of #3359 in this pull request. This makes it very hard to review. Please rebase the card_height related change on the main branch 😅.

@rickstaa
Copy link
Collaborator

@airwakz we received a similar pull request from @DanneelsSophie which, since it doesn't contain non-relevant code, is a bit easier to review. As a result, I closed this pull request in favour of #https://github.com/anuraghazra/github-readme-stats/pull/3391/files. I attached the hacktoberfest-accepted label to ensure your contributions are still counted against the hacktoberfest hackathon 👍🏻. Thanks for your contribution.

@rickstaa rickstaa closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. hacktoberfest-accepted lang-card Issues related to the language card. repo-card Issues related to the pin/repo card. stats-card Feature, Enhancement, Fixes related to stats the stats card.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants