Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update repo-card.js #2951 #3421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Simer13
Copy link

@Simer13 Simer13 commented Oct 24, 2023

Made some minor changes to enhance the repo-card, in order to enhance the presentation of the repo and make it look better.

Made some minor changes to enhance the reop-card.
@vercel
Copy link

vercel bot commented Oct 24, 2023

@Simer13 is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the repo-card Issues related to the pin/repo card. label Oct 24, 2023
Copy link
Collaborator

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @Simer13! I see two problems with this pull request.

First, the default behavior of the card should be kept as is, our users do not expect that cards in their profiles will be suddenly changed without action from their side. If you want repository card to have an alternate layout, it should be implemented as querystring parameter, same way as it was already implemented with our top languages card https://github.com/anuraghazra/github-readme-stats#demo-2.

And the second, if you want to add this just for your personal use, you are able to deploy your branch on own Vercel instance, let's first create feature request issue and track if our community want it to be implemented since there is no sense in adding this if no one will use it.

Let's also wait for other maintainers input.

@Simer13
Copy link
Author

Simer13 commented Oct 26, 2023

@qwerty541 Thanks for the input. You are right we can implement this as a new feature rather than making changes to the original card itself. We can create a new issue in relation to this topic and wait for the community's input and interest in the suggested feature. The new feature can be given either as an option or alternative to the user to select according to their type.
Furthermore, we can also create a feature in another issue to let them modify the card in the way they want to represent it for their particular instance.

@qwerty541
Copy link
Collaborator

@qwerty541 Thanks for the input. You are right we can implement this as a new feature rather than making changes to the original card itself. We can create a new issue in relation to this topic and wait for the community's input and interest in the suggested feature. The new feature can be given either as an option or alternative to the user to select according to their type. Furthermore, we can also create a feature in another issue to let them modify the card in the way they want to represent it for their particular instance.

@Simer13 Let's start from creating feature request issue and wait for community's response in form of 👍. Please attach there a screenshot of the new card appereance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo-card Issues related to the pin/repo card.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants