Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraphQL ~> 1.12 to test matrix and allow to use other GraphQL version #16

Merged
merged 1 commit into from Feb 11, 2021

Conversation

arathunku
Copy link
Contributor

All specs pass on GraphQL 1.12, GRAPHQL_RUBY_INTERPRETER is used by default on this version.

There were also no changes to:

  if TESTING_GRAPHQL_RUBY_INTERPRETER
    extend GraphQL::Subscriptions::SubscriptionRoot
  end

because https://graphql-ruby.org/api-doc/1.11.6/GraphQL/Subscriptions/SubscriptionRoot.html Deprecated. This module is no longer needed.

Copy link
Member

@Envek Envek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! In general it is looking good to me. I have one small suggestion to improve test matrix, though.

.github/workflows/test.yml Show resolved Hide resolved
@Envek Envek merged commit cf8f4fa into anycable:master Feb 11, 2021
@Envek
Copy link
Member

Envek commented Feb 11, 2021

Thank you! 🙏

@arathunku
Copy link
Contributor Author

arathunku commented Feb 11, 2021

No, thank you, @Envek!!! I'll be able to resume work on GraphQL upgrade in the morning 😄

@arathunku arathunku deleted the allow-graphql-1.12 branch February 11, 2021 18:35
@arathunku
Copy link
Contributor Author

@Envek, is there a chance for a release sometime in the future?

@Envek
Copy link
Member

Envek commented Feb 15, 2021

But why do you need a release for this? This PR doesn't really changes runtime behaviour of the gem.

@arathunku
Copy link
Contributor Author

Ahhhhhhhh, nvm, I needed to include graphql-anycable in bundle update explicitly 🤦 Please ignore me, everything is looking alright!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants