Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQ-9448 Fix persistent scheduler deadlock #1177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thezbyg
Copy link
Contributor

@thezbyg thezbyg commented Mar 16, 2024

Do not fire or schedule jobs while holding read lock on store.

@thezbyg
Copy link
Contributor Author

thezbyg commented Mar 16, 2024

Please use existing org.apache.activemq.broker.scheduler.JmsSchedulerTest#testCron test to confirm that persistent scheduler currently deadlocks on CRON jobs. This is not the same deadlock as reported in AMQ-9448, but it is caused by the same reason.

@jbonofre jbonofre self-requested a review March 17, 2024 10:48
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add a unit test to illustrate how deadlock can happen and this change actually fix it.

Do not fire or schedule jobs while holding read lock on store.
@thezbyg thezbyg force-pushed the fix-persistent-scheduler-deadlock branch from bd33b42 to 0448cf2 Compare March 20, 2024 06:15
@thezbyg
Copy link
Contributor Author

thezbyg commented Mar 20, 2024

I have now added a new unit test. Does existing JmsSchedulerTest#testCron unit test run successfully for you before this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants