Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around typing issue in examples and providers #35494

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Work around typing issue in examples and providers #35494

merged 7 commits into from
Nov 7, 2023

Commits on Nov 7, 2023

  1. Work around typing issue in workday examples 

    Since this is just an example, we'll just ignore this and not worry
too much about it.
    @uranusjr
    uranusjr committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    8dc9bfd View commit details
    Browse the repository at this point in the history

  2. Rewrite Pandas column-renaming 

    The assignment syntax doesn't seem to be type-safe (although working at
runtime), let's use a more semantic method.
    @uranusjr
    uranusjr committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    c036afb View commit details
    Browse the repository at this point in the history

  3. Fix commin.sql arg type to Pandas 

    Some of the parameters were too lax for Pandas and need to be tightened
up.
    @uranusjr
    uranusjr committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    9faf4e9 View commit details
    Browse the repository at this point in the history

  4. More column rename fixes

    @uranusjr
    uranusjr committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    7c57c00 View commit details
    Browse the repository at this point in the history

  5. Work around strict Numpy typing 

    This seems to be a definition issue between Numpy and Pandas? Not sure,
but this works at runtime so let's not dig too deep. Simply annotating
the variable as Any is enough to work around the problem.
    @uranusjr
    uranusjr committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    2265171 View commit details
    Browse the repository at this point in the history

  6. Work around complex Pandas typing 

    This is just too much. Let's cast and not worry about it.
    @uranusjr
    uranusjr committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    e2d052b View commit details
    Browse the repository at this point in the history

  7. More parameters type fixes

    @uranusjr
    uranusjr committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    281bc80 View commit details
    Browse the repository at this point in the history