Refactor DAG.dataset_triggers into the timetable class #39321
+176
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
dag-schedule-refactor
branch
from
2dbc042
to
e926a8c
Compare
uranusjr
changed the title
uranusjr
force-pushed
the
dag-schedule-refactor
branch
2 times, most recently
from
409ef81
to
e06212b
Compare
This allows us to remove a bunch of conditionals regarding whether a DAG is backed by a timetable or dataset condition, and a weird edge case in serialization where we don't actually deserialize datasets in a timetable. Now datasets are always serialized as a part of the timetable, and we always evaluate the timetable and datasets. Timetables that do not actually contain datasets (most of them) simply always evaluate to False.
uranusjr
force-pushed
the
dag-schedule-refactor
branch
from
e06212b
to
54fdeb7
Compare
uranusjr
requested review from
kaxil,
ashb,
bolkedebruin and
XD-DENG
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove a bunch of conditionals regarding whether a DAG is backed by a timetable or dataset condition, and a weird edge case in serialization where we don't actually deserialize datasets in a timetable.
Now datasets are always serialized as a part of the timetable, and we always evaluate the timetable and datasets. Timetables that do not actually contain datasets (most of them) simply always evaluate to False.