Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move core system tests outside of providers system tests #39335

Merged
merged 2 commits into from May 7, 2024

Conversation

Taragolis
Copy link
Contributor

This tests for Core, not providers, so better store it separatly.
I'm not sure but maybe we should move it into the airflow/example_dags


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@RNHTTR
Copy link
Collaborator

RNHTTR commented Apr 30, 2024

Will this also fix the associated "[source]" link that's currently broken?

image

It seems like the existing link should work even if it doesn't belong under providers.

@Taragolis
Copy link
Contributor Author

Taragolis commented Apr 30, 2024

I'm not sure this one fix link to the sources. Because these directory not included into the build this kind of sources in apache-airflow documentation.

I could have a look tomorrow morning, as other solution move it into the example_dags

@Taragolis Taragolis requested a review from kaxil as a code owner May 1, 2024 08:10
@Taragolis
Copy link
Contributor Author

@RNHTTR After minor changes in doc configurations tests/system/coreavailable into the apache-airflow documentation

apache-airflow-system-tests-doc-demo.mp4

@Taragolis Taragolis added this to the Airflow 2.9.2 milestone May 3, 2024
@Taragolis Taragolis merged commit e299ac9 into apache:main May 7, 2024
41 checks passed
@Taragolis Taragolis deleted the move-core-system-tests branch May 7, 2024 14:59
Copy link

boring-cyborg bot commented May 7, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
* Move core system tests outside of providers system tests

* Add system tests into apache-airflow documentation toctree
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
* Move core system tests outside of providers system tests

* Add system tests into apache-airflow documentation toctree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow area:system-tests kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants