-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD prototype version dark mode for Airflow UI #39355
Open
YounHS
wants to merge
18
commits into
apache:main
Choose a base branch
from
YounHS:secy_branch
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+81
−1
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c47482b
ADD prototype version dark mode for Airflow UI
eadcd23
fix flickering when refresh page
fce5c71
Merge branch 'main' into secy_branch
YounHS 43a2d96
clean up commented code
58767ae
indent fix tab to 2 indent
cfb8bb8
Merge branch 'main' into secy_branch
YounHS 87098ec
add comment for linter
ab1f041
Merge branch 'main' into secy_branch
YounHS 5b1c374
fix to simple code, but to require refactoring in the future
YounHS 87eee0e
Merge branch 'main' into secy_branch
YounHS 8d7f34d
flickering fix optimization
edbbd2b
Merge branch 'main' into secy_branch
YounHS 6654e98
Merge branch 'main' into secy_branch
YounHS a479a4b
Merge branch 'main' into secy_branch
YounHS b9c0b33
lint fix
732896d
fix lint
95924eb
final lint error fix
3ed864d
dark/light mode icon toggle
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/*! | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
/* global document, localStorage, window */ | ||
|
||
const STORAGE_THEME_KEY = "darkTheme"; | ||
const HTML_THEME_DATASET_KEY = "data-color-scheme"; | ||
const HTML = document.documentElement; | ||
const TOGGLE_BUTTON_ID = "themeToggleButton"; | ||
|
||
const getJsonFromStorage = (key) => JSON.parse(localStorage.getItem(key)); | ||
const updateTheme = (isDark) => { | ||
localStorage.setItem(STORAGE_THEME_KEY, isDark); | ||
HTML.setAttribute(HTML_THEME_DATASET_KEY, isDark ? "dark" : "light"); | ||
}; | ||
const initTheme = () => { | ||
const isDark = | ||
getJsonFromStorage(STORAGE_THEME_KEY) ?? | ||
window.matchMedia("(prefers-color-scheme: dark)").matches; | ||
updateTheme(isDark); | ||
}; | ||
const toggleTheme = () => { | ||
const isDark = getJsonFromStorage(STORAGE_THEME_KEY); | ||
updateTheme(!isDark); | ||
}; | ||
window.addEventListener("click", (e) => { | ||
if (e.target.id !== TOGGLE_BUTTON_ID) return; | ||
toggleTheme(); | ||
}); | ||
window | ||
.matchMedia("(prefers-color-scheme: dark)") | ||
.addEventListener("change", (e) => { | ||
const isDark = e.matches; | ||
updateTheme(isDark); | ||
}); | ||
initTheme(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,6 +50,16 @@ | |
{% include 'appbuilder/navbar_menu.html' %} | ||
</ul> | ||
<ul class="nav navbar-nav navbar-right"> | ||
<li class="active"> | ||
<div style="padding: 20px; cursor: pointer" id="themeToggleButton"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's add a title and aria-label saying something like "Toggle dark mode (experimental)" |
||
<div id="dark_icon"> | ||
<i class="fa-regular fa-moon fa-lg" id="themeToggleButton"></i> | ||
</div> | ||
<div id="light_icon"> | ||
<i class="fa-regular fa-sun fa-lg" id="themeToggleButton"></i> | ||
</div> | ||
</div> | ||
</li> | ||
{% include 'appbuilder/navbar_right.html' %} | ||
</ul> | ||
</div> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the automatic detection and only use user actions + localstorage for now.