retry for failure in the queue #39398
Draft
+30
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:core-operators
Taragolis
requested changes
May 4, 2024
| self.fail(task_instance_key, None) | ||
| self.failed_in_queue(task_instance_key, None) |
There was a problem hiding this comment.
This one is backward incompatible change with Airflow 2.7, 2.8 and 2.9.
Maybe it is also a good idea to made separate PR in Core and and after in Provider(s)
There was a problem hiding this comment.
ah i see. let me do that @Taragolis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #38304
I think to have a retry option specifically for the failure happening in queue, we need to have a separate state where we need to indicate that failure is happening due to longer queue timeout and then segregate the retry for it there. Please let me know if I am going in right direction or do you think I have to think this in different approach?
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.