Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only heartbeat if necessary in backfill loop #39399

Merged
merged 2 commits into from
May 6, 2024
Merged

Only heartbeat if necessary in backfill loop #39399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a25b9b9
Only heartbeat if necessary in backfill loop
dstandish May 3, 2024
9794b33
sleep each loop
dstandish May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 4 additions & 5 deletions airflow/jobs/backfill_job_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
from airflow.ti_deps.dependencies_deps import BACKFILL_QUEUED_DEPS
from airflow.timetables.base import DagRunInfo
from airflow.utils import helpers, timezone
from airflow.utils.configuration import conf as airflow_conf, tmp_configuration_copy
from airflow.utils.configuration import tmp_configuration_copy
from airflow.utils.log.logging_mixin import LoggingMixin
from airflow.utils.session import NEW_SESSION, provide_session
from airflow.utils.state import DagRunState, State, TaskInstanceState
Expand Down Expand Up @@ -475,10 +475,8 @@ def _process_backfill_task_instances(
"""
executed_run_dates = []

is_unit_test = airflow_conf.getboolean("core", "unit_test_mode")

while (ti_status.to_run or ti_status.running) and not ti_status.deadlocked:
self.log.debug("*** Clearing out not_ready list ***")
self.log.debug("Clearing out not_ready list")
ti_status.not_ready.clear()

# we need to execute the tasks bottom to top
Expand Down Expand Up @@ -697,7 +695,7 @@ def _per_task_process(key, ti: TaskInstance, session):
self.log.debug(e)

perform_heartbeat(
job=self.job, heartbeat_callback=self.heartbeat_callback, only_if_necessary=is_unit_test
job=self.job, heartbeat_callback=self.heartbeat_callback, only_if_necessary=True
)
# execute the tasks in the queue
executor.heartbeat()
Expand Down Expand Up @@ -749,6 +747,7 @@ def to_keep(key: TaskInstanceKey) -> bool:

self._log_progress(ti_status)
session.commit()
time.sleep(1)

# return updated status
return executed_run_dates
Expand Down