Add args to docker service ContainerSpec #39464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
reviewed
May 7, 2024
dirrao
reviewed
May 8, 2024
Taragolis
approved these changes
May 8, 2024
RNHTTR
pushed a commit
to RNHTTR/airflow
that referenced
this pull request
Jun 1, 2024
* Add args to docker service ContainerSpec * args is a list in ContainerSpec * fix ContainerSpec assertion * fix args formatter * fix ContainerSpec assert * remove some spaces * add docker service args list test case * replace ast.literal_eval with json.loads * remove json string representation --------- Co-authored-by: Guy Driesen <19373791+guydriesen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for defining arguments to the DockerSwarmOperator.
The currently available command option replaces the entrypoint on a docker service container, with the args you can give extra options to the entrypoint.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.