DbAPiHook: Don't log a warning message if placeholder is None and make sure warning message is formatted correctly #39690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the placeholder is invalid that the warning message is logged correctly
2 tasks
Taragolis
reviewed
May 17, 2024
Taragolis
approved these changes
May 17, 2024
dabla
changed the title
dirrao
approved these changes
May 18, 2024
RNHTTR
pushed a commit
to RNHTTR/airflow
that referenced
this pull request
Jun 1, 2024
…e sure warning message is formatted correctly (apache#39690) * fix: Don't log a warning message if placeholder is None and make sure if the placeholder is invalid that the warning message is logged correctly * refactor: Also make sure to verify that log.warning isn't invoked when placeholder is valid * refactor: All assertions regarding the logging are now done through caplog * refactor: Reformatted logging assertions * refactor: Reformatted logging assertion --------- Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #39678
This PR fixes an invalid warning message being logged when placeholder is None (and thus not defined in the connection extra field) and also makes sure that when the placeholder isn't valid, a correct warning message is being logged.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.