Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pattern for split Log to independent messages #39700

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Zoynels
Copy link

@Zoynels Zoynels commented May 18, 2024

Add two ways to fix the difference between logs which stores in files and logs in UI:

  1. Custom re.pattern which can split whole log into "real" messages
  2. Disable deduplication of log lines

closes: #39686


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented May 18, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Zoynels Zoynels changed the title Add pattern for split Log to independent messages (#39686) Add pattern for split Log to independent messages May 18, 2024
…r way to store multiline messages)

rename flag_name to pass spellcheck
simplify function and pattern
* currently it splits all lines by \n and then check each line that it match pattern (then it start new message)
use re2 package
@Zoynels Zoynels requested a review from eladkal May 26, 2024 05:29
now we read file as-is, without strip new lines at the end of the file

s3 - we write \n at the end of the file and then we recieve this \n.

if we didn't write \n then we read equal text
@Zoynels Zoynels requested a review from o-nikolas as a code owner May 30, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference between logs which stores in files and logs in UI
2 participants