Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: During startup, etcd reported an error. #546

Conversation

WarriorFromLongAgo
Copy link

docker-compose
docker-compose-arm64

"docker-compose -f docker-compose.yml -p docker-apisix up -d", Due to the lack of setting etcd_data, an error occurred.

@monkeyDluffy6017
Copy link
Contributor

I don't think there is any difference between the 2 styles?

@WarriorFromLongAgo
Copy link
Author

我不认为这两种风格之间有什么区别?

now: etcd_data:/bitnami/etcd
update: ./etcd_data:/bitnami/etcd

If I execute this command ‘etcd_data:/bitnami/etcd’, it will report that the folder does not exist.

If I execute this command './etcd_data:/bitnami/etcd', it will generate 'etcd_data' in the current directory.

@monkeyDluffy6017
Copy link
Contributor

monkeyDluffy6017 commented Feb 27, 2024

. /file uses the . / prefix to explicitly specify a file or directory in the current directory. This is a relative path representation, where . represents the current working directory. Using this makes the intent of the path clearer, indicating that you are actually trying to find the file or directory from the current directory.
file does not specify a path, just the name of the file or directory. In Docker Compose, if no path is specified (i.e., there is no leading path separator such as . / or / ), this is also treated as a relative path to the directory where the current docker-compose.yml file is located. Although in effect, file and . /file are identical in most cases, omitting . / may make the origin and intent of the path slightly less clear.
So the two style is the same, could you deep into this?

@WarriorFromLongAgo
Copy link
Author

You are correct. However, there are two issues.
1, this is just an example. For new users, it would be better if they could use it immediately after starting without having to specify another file (etcd_data).
2, the representation of 'etcd_data' is inconsistent between docker-compose.yml and docker-compose-arm64.yml.

您说得对。但是,有两个问题。
1,这只是一个示例。对于新用户来说,启动后立即可用而无需指定另一个文件(etcd_data)会更好。
2,在docker-compose.yml和docker-compose-arm64.yml中,'etcd_data'的表示方式不一致。

Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 27, 2024
Copy link

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants