Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFusion Substrait blog post #322

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andygrove
Copy link
Member

No description provided.

@andygrove
Copy link
Member Author

@jdye64 @nseekhao fyi

@alamb
Copy link
Contributor

alamb commented Feb 23, 2023

The build scripts seem to be broken

https://github.com/apache/arrow-site/actions/runs/4243705123/jobs/7376801156


17 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
npx webpack --mode=production
rm -f javascript/main.js
node:internal/crypto/hash:71
  this[kHandle] = new _Hash(algorithm, xofLen);

@kevingurney
Copy link
Member

kevingurney commented Feb 28, 2023

@alamb - it seems like the Webpack issues linked below may be causing the build failure:

  1. nodejs 17: digital envelope routines::unsupported webpack/webpack#14532 (comment)
  2. Webpack Hash is not FIPS-Compliant webpack/webpack#13572
  3. allow to configure all hash functions used webpack/webpack#14306

My high level understanding is that in Node 18 (the build output shows Node.js v18.14.1 is being used), the md4 hashing algorithm is deprecated (more specifically, it seems that Node 18 uses OpenSSL 3.0, and md4 is deprecated in OpenSSL 3.0) and the version of Webpack used by apache/arrow-site (v5.21.2) seems to default to using md4.

Webpack v5.61.0 added a WASM md4 implementation as a fallback. However, the advice in 1. recommends setting output.hashFunction in the Webpack config to use an alternative hashing algorithm instead. Specifically, it recommends using xxhash64 (which is planned to be the default hashing algorithm when Webpack 6 is released).

So, to summarize, it seems that a combination of upgrading to the latest version of Webpack and switching over to xxhash64 may resolve this issue.

@kevingurney
Copy link
Member

kevingurney commented Feb 28, 2023

After some more investigation, I discovered that the default Node.js version was switched to 18 for the ubuntu-latest GitHub Actions runner image on February 13th. This appears to explain why this build failure started appearing a few weeks ago.

Given this information, an alternative approach to the one detailed in my previous comment would be to pin the Node.js version used by the GitHub Actions runner to version 16 for the setup-node action. Of course, this would mean we would be continuing to rely on an outdated version of Node.js, which doesn't seem ideal in the long term.

@kevingurney
Copy link
Member

I've captured this issue as a Bug with the Component set to [Website] in #34379 in the apache/arrow project.

@avantgardnerio
Copy link

After some more investigation, I discovered that...

Personally, I would recommend that we switch away from the proprietary, arbitrarily changing, and non-locally debuggable ubuntu-latest and to the official locally-runnable docker image ubuntu:latest where possible as we did here:

https://github.com/apache/arrow-ballista/blob/b61cfbf54705f4cbfcbc7103f87509e49cd01fda/.github/workflows/rust.yml#L79

@kevingurney
Copy link
Member

kevingurney commented Feb 28, 2023

Thanks @avantgardnerio! Agreed - this seems like a good solution. It would be great to not have to worry about things changing suddenly in ubuntu-latest. I've added this to the list of potential workarounds in #34379.

@alamb
Copy link
Contributor

alamb commented Feb 28, 2023

Thanks @avantgardnerio! Agreed - this seems like a good solution. It would be great to not have to worry about things changing suddenly in ubuntu-latest. I've added this to the list of potential workarounds in #325.

Awesome -- could someone make a PR to this repo?

@kevingurney
Copy link
Member

@alamb - yes, I just assigned the issue to myself and will make a PR

@kevingurney
Copy link
Member

Update: I've opened pull request #326 to address the build issues.

@alamb
Copy link
Contributor

alamb commented Mar 31, 2023

The doc build has been fixed -- do we still want to publish this content?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants