Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41711: [C++] macros.h: Fix ARROW_FORCE_INLINE for MSVC #41712

Merged
merged 1 commit into from
May 17, 2024

Conversation

felipecrv
Copy link
Contributor

@felipecrv felipecrv commented May 17, 2024

Rationale for this change

Define the macro correctly. Nothing is broken at the moment because the macro is not used within Arrow at the moment.

What changes are included in this PR?

Correct definition of the macro.

Are these changes tested?

Yes, by having this commit in other PRs that pass CI tests on Windows.

@felipecrv felipecrv requested a review from bkietz May 17, 2024 17:57
Copy link

⚠️ GitHub issue #41711 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit a04339a into apache:main May 17, 2024
37 of 38 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label May 17, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label May 17, 2024
@felipecrv felipecrv deleted the fix_macro branch May 17, 2024 22:13
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit a04339a.

There was 1 benchmark result with an error:

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…he#41712)

### Rationale for this change

Define the macro correctly. Nothing is broken at the moment because the macro is not used within Arrow at the moment.

### What changes are included in this PR?

Correct definition of the macro.

### Are these changes tested?

Yes, by having this commit in other PRs that pass CI tests on Windows.
* GitHub Issue: apache#41711

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants