Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39345: [C++][FS][Azure] Add support for environment credential #41715

Conversation

Tom-Newton
Copy link
Contributor

@Tom-Newton Tom-Newton commented May 18, 2024

Rationale for this change

Maybe be useful to support explicit environment credential (currently environment credential can be used as part of the Azure default credential flow).

What changes are included in this PR?

Are these changes tested?

There are new unittests but no integration tests that we can actually authenticate successfully. We are relying on the Azure C++ SDK to abstracting that away.

Are there any user-facing changes?

Yes, environment credential is now available.

Copy link

⚠️ GitHub issue #39345 has been automatically assigned in GitHub to PR creator.

@Tom-Newton Tom-Newton marked this pull request as ready for review May 18, 2024 23:08
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Could you also update docstring?

/// * credential_kind: One of "default", "anonymous",
/// "workload_identity". If "default" is specified, it's just
/// ignored. If "anonymous" is specified,
/// AzureOptions::ConfigureAnonymousCredential() is called. If
/// "workload_identity" is specified,
/// AzureOptions::ConfigureWorkloadIdentityCredential() is called.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 19, 2024
Copy link
Contributor

@felipecrv felipecrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that "default" would cause the Azure SDK to automatically try to get auth parameters from the environment.

@Tom-Newton
Copy link
Contributor Author

Tom-Newton commented Jun 2, 2024

I thought that "default" would cause the Azure SDK to automatically try to get auth parameters from the environment.

It does but only if none of the other Auth options earlier in the chain are successful. Sometimes it's useful to be specific. E.g. if the system has multiple auths configured or if you want to quickly return an error instead of going through trying all the auths.

@kou kou merged commit 02585cd into apache:main Jun 3, 2024
37 of 38 checks passed
@kou kou removed the awaiting merge Awaiting merge label Jun 3, 2024
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 02585cd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 71 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants