Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-3732: [gradle-plugin] import gradle plugin from gradle-avro-plugin #2310

Merged
merged 521 commits into from
May 20, 2024
Merged

AVRO-3732: [gradle-plugin] import gradle plugin from gradle-avro-plugin #2310

merged 521 commits into from
May 20, 2024

Conversation

SingingBush
Copy link

@SingingBush SingingBush commented Jun 29, 2023 •
edited

This PR is for the pulling in the source donation from https://github.com/davidmc24/gradle-avro-plugin

please see comment in https://issues.apache.org/jira/browse/AVRO-3732

davidmc24 and others added 30 commits October 14, 2019 22:05
@davidmc24
Try again to avoid gradle welcome banner in CI
482f457
@davidmc24
ci: try turning on github actions compatibility tests
a89d14d
@davidmc24
fix ci syntax
bc0e047
@davidmc24
ci: fix yaml indentation
16f1213
@davidmc24
ci: comment out fail fast
6024013
@davidmc24
ci: fix matrix structure
f6addc8
@davidmc24
CI: try matrix with allowed failures
4e7e41c
@davidmc24
CI: give up on conditional failures allowed for now; exclude java 13
986a35c
@davidmc24
CI: info output for builds
e06261f
@davidmc24
Try to resolve the test failures on windows regarding default encodin…
ada5123 
…g handling
@davidmc24
Fix encoding support on windows, for real this time
9c376d5
@davidmc24
CI: add unsupported-java-versions job
7bf9337
@davidmc24
CI: run the unsupported java versions job on all the OS versions
7d9b9be 
After all, they'll all fail almost immediately anyway
@davidmc24
README: Update badge to use github actions rather than travis
29103e0
add support for generating optional getters
2c8725e
@davidmc24
README: fix CI badge syntax
e375c75
@davidmc24
README: fix CI badge image
a2e1725
@davidmc24
Merge branch 'github-actions'
9c83b7d
add doc for optional getter field generation
cbcce71
@davidmc24
Merge pull request apache#90 from bspeakmon/feature/add-optional-type…
1d5674a 
…-support

Add support for generating getters that return Optional
@davidmc24
Update changelog to note the recent merged pull request
7aa5f6f
@davidmc24
CI: disable the gradle daemon to try to eliminate the sporadic clean …
e4b09a4 
…failure on windows
@davidmc24
Remove security policy; not a CommerceHub OSS project any more
7da5f43
@davidmc24
Update various files for commercehub-oss -> davidmc24 github move
95f992d
@davidmc24
Working version of custom conversions against modern gradle; still ne…
5fa162d 
…ed to adjust for earlier versions
@davidmc24
Don't use MapProperty yet; it wasn't introduced until Gradle 5.1
bb62c99
@davidmc24
Don't use ListProperty
a861cf2 
It changed incompatibly between Gradle 4.4 and Gralde 4.5
@davidmc24
Don't use Class.newInstance(), as it was deprecated in Java 11
f0b1206
@davidmc24
Update issue templates
5070f7e
@davidmc24
Update bug_report.md to add a checklist
6483614
erdi and others added 14 commits April 4, 2023 16:33
@erdi
Add documentation for using conversions and type factories located ou…
09fafb2 
…tside of build classpath
@erdi
Add deprecations for methods used to configure conversions and type f…
b4ac5ba 
…actories with classes
@davidmc24
Merge pull request apache#228 from erdi/conversions-and-type-factorie…
457b926 
…s-outside-build-classpath

Add ability to use conversions and type factories residing outside of build classpath
@davidmc24
Prep for 1.7.0 release
dda836f
@davidmc24
version: 1.7.1-SNAPSHOT
55608b3
Fix vulnerabilities in transitive dependencies
036875f
@davidmc24
Merge pull request apache#229 from BlacCello/fix-vuln
92a6fd9 
Fix vulnerabilities in transitive dependencies
@davidmc24
version: 1.7.1
a81ffc6
@davidmc24
version: 1.7.2-SNAPSHOT
bf84ab2
@davidmc24
Update github actions that ran in node 12
17210cd
@TopHatCroat
Fix Kotlin DSL setup snippet
a953c19
@davidmc24
Merge pull request apache#231 from TopHatCroat/master
194db28
@SingingBush
move everything to lang/java/gradle-plugin
cb17b3d
@SingingBush
merge gradle-avro-plugin
3bc92f3
@github-actions github-actions bot added build Java Pull Requests for Java binding labels Jun 29, 2023
@RyanSkraba
Copy link
Contributor

Hey we need to do another 1.11.x release ... I'll get to this review when that's finished! (In the meantime, other's comments and review are always welcome. The right place for discussion and defining the future work is probably in the JIRA!)

@RyanSkraba RyanSkraba changed the title AVRO-3732 [gradle-plugin] import gradle plugin from gradle-avro-plugin AVRO-3732: [gradle-plugin] import gradle plugin from gradle-avro-plugin Aug 18, 2023
@PPrydorozhnyi
Copy link

Hello, guys. Sorry if this is the wrong place to ask questions.

The adaptation process started quite some time ago, the old code is no longer supported and no activity indicates that the process is ongoing. Please tell me if there are any plans to support this plugin or is it better not to even start using it?

In any case, thank you!

@RanbirK
Copy link

RanbirK commented Apr 11, 2024 •
edited

Hello, guys. Sorry if this is the wrong place to ask questions.

The adaptation process started quite some time ago, the old code is no longer supported and no activity indicates that the process is ongoing. Please tell me if there are any plans to support this plugin or is it better not to even start using it?

In any case, thank you!

Would love to see some updates on this given https://github.com/davidmc24/gradle-avro-plugin was archived in Oct 2023?

@SingingBush
Copy link
Author

I think either https://issues.apache.org/jira/browse/AVRO-3732 or the Apache mailing lists are probably the place to discuss. My understanding was that Ryan or someone else in the ASF was going to pick it up.

@the-coffee-guy
Copy link

Uh, that's currently an unsafe intermediate state. Hopefully the old maintainer will take up the work again, or someone will fork it.

@davidmc24
Copy link

davidmc24 commented Apr 15, 2024 •
edited

Speaking as the former maintainer, I've already put in a decade maintaining it for free, most of which was after I ceased to have any personal use for it. Anyone who wants to is free to fork.

@RyanSkraba
Copy link
Contributor

Hey @davidmc24 -- just to repeat our thanks for donating this plugin, your many years of work are really appreciated!

I'm converting this PR to draft, since it shouldn't be merged and released "as-is" (although thanks so much to @SingingBush for getting this very necessary step together), but the right place to discuss and volunteer for the next steps is either the mailing list or the umbrella JIRA at AVRO-3731!

@RyanSkraba RyanSkraba marked this pull request as draft April 18, 2024 15:02
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this pull request May 14, 2024
Closed
@martin-g martin-g changed the base branch from main to avro-3731-gradle-avro-plugin May 20, 2024 09:02
@martin-g martin-g marked this pull request as ready for review May 20, 2024 09:03
@martin-g martin-g merged commit cd9a7a0 into apache:avro-3731-gradle-avro-plugin May 20, 2024
11 of 141 checks passed
@martin-g
Copy link
Member

The PR has been merged to branch avro-3731-gradle-avro-plugin.
Any further PRs should be targeted against this branch until the build is stable and the CI checks are green! Only then this base branch could be merged to the main branch!

@olahungerford @RanbirK ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Java Pull Requests for Java binding
Projects
None yet
Milestone
No milestone