Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3933: Unify ARM64 workflows #2722

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

zcsizmadia
Copy link
Contributor

What is the purpose of the change

Unify ARM64 build workflows (AVRO-3933)

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the build label Feb 1, 2024
@zcsizmadia zcsizmadia marked this pull request as draft February 1, 2024 21:24
@zcsizmadia
Copy link
Contributor Author

@martin-g This PR is a POC to unify the ARM64 workflow with the regular x64 based workflow. The most important thing is that the same (as much as possible) worklfow is used for x64 and ARM64 (using build matrix).

@nielsbasjes Not sure if this PR is a step back for your issue yesterday

@nielsbasjes
Copy link
Contributor

I'm fine with this step as soon as the ARM build servers are reliable.

Are these servers reliable now?
If not yet then I think this should wait till they are.

Note that the README.md also needs changes as part of this merge request.

@zcsizmadia
Copy link
Contributor Author

Roger. So based on your PR you just wanted simply make it visible that ARM failed, so we can ignore it (since it is an issue of the self hosted runner)

@zcsizmadia
Copy link
Contributor Author

Using the github hosted macos-14 runner is an option, however that is a MacOS image with ARM64 M1 processor. Not Ubuntu like the other runners we use, so most likely a good amount work would be needed to make everything build on MacOS. But, that would remove the external build server dependency.

@nielsbasjes
Copy link
Contributor

Roger. So based on your PR you just wanted simply make it visible that ARM failed, so we can ignore it (since it is an issue of the self hosted runner)

Yes exactly. Before my patch it showed that the Java build failed. A deeper dive into the logging was needed to reveal that it was the ARM runner ... again.

With this split this became easier to inspect.

I fully like your approach to consolidate the builds over all architectures.
If I understand correctly; Going the macos route would mean having them all separate again?

@nielsbasjes
Copy link
Contributor

Apparently simply having this in Github Actions has been a feature request for about 2 years now actions/runner-images#5631

@zcsizmadia
Copy link
Contributor Author

Yeah, it is a big missing piece from Github. Hopefully soon it is released. Github announced last year that ARM runners are coming this year.

https://github.blog/changelog/2023-10-30-accelerate-your-ci-cd-with-arm-based-hosted-runners-in-github-actions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants