AVRO-3947: [Java] Support subclasses in custom LogicalType Conversions #2766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently
GenericData.resolveUnion(schema, datum)
will throw anAvroRuntimeException
if datum is a subclass (or any instance) of the target type of an applicable logical type Conversion. For instance"ip-address"
logical type string converter to/fromjava.net.InetAddress
(withInet4Address
,Inet6Address
as subclasses)"json"
logical type string conversion to/from Jackson'sJsonNode
(withObjectNode
,ArrayNode
, etc as subclasses)This PR fixes AVRO-3947.
Verifying this change
A unit test was added to validate that
GenericData.resolveUnion(schema, datum)
behaves as intended.Documentation