Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-3965: [Rust] Default values for fixed can be longer than size #2907

Merged
merged 1 commit into from
May 15, 2024
Merged

AVRO-3965: [Rust] Default values for fixed can be longer than size #2907

merged 1 commit into from
May 15, 2024

Conversation

martin-g
Copy link
Member

What is the purpose of the change

  • Return an error if the default value's length is not the same as the specified size of a Fixed schema

Verifying this change

  • Old and new unit tests should pass

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@martin-g
AVRO-3965: [Rust] Default values for fixed can be longer than size
6c05e0d 
Return an error if the default value's length is not the same as the
specified size of a Fixed schema

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@github-actions github-actions bot added the Rust label May 14, 2024
@martin-g martin-g merged commit 0661bfe into main May 15, 2024
15 checks passed
@martin-g martin-g deleted the avro-3965-default-len-bigger-than-size branch May 15, 2024 07:38
martin-g added a commit that referenced this pull request May 15, 2024
@martin-g
AVRO-3965: [Rust] Default values for fixed can be longer than size (#…
82fa91c 
…2907)

Return an error if the default value's length is not the same as the
specified size of a Fixed schema

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
(cherry picked from commit 0661bfe)
@mitasov-ra
Copy link
Contributor

@martin-g AVRO-3965 is about Java component, is it okay that this PR mentions this issue?

@martin-g
Copy link
Member Author

I see no problem with reusing the same ticket for an issue that affects several SDKs.
The Jira ticket won't be closed until the Java SDK is improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Rust
Projects
None yet
Milestone
No milestone
2 participants
@martin-g @mitasov-ra