Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2811:Upgrade grpc 1.26 to 1.28 #863

Merged
merged 1 commit into from Apr 26, 2020
Merged

Conversation

zeshuai007
Copy link
Member

@zeshuai007 zeshuai007 commented Apr 23, 2020

This PR does not involve scenario use cases, just associate grpc ticket.
Eg:
grpc/grpc-java#6601

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@probot-autolabeler probot-autolabeler bot added build Java Pull Requests for Java binding labels Apr 23, 2020
@RyanSkraba
Copy link
Contributor

Relaunched the windows build on this!

@zeshuai007
Copy link
Member Author

Has been compiled and verified through Windows 10 + java8.

@Fokko Fokko merged commit b6f4970 into apache:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Java Pull Requests for Java binding
Projects
None yet
3 participants