Skip to content

Commit

Permalink
Update google-api-services-storage to match libraries-bom (#29865)
Browse files Browse the repository at this point in the history
```
cd /tmp; wget https://repo1.maven.org/maven2/com/google/cloud/libraries-bom/26.28.0/libraries-bom-26.28.0.pom -O base.pom && mvn help:effective-pom -f base.pom -Doutput=effective.pom && cat effective.pom | grep -v 'dependencyManagement' > cleanup.pom && mvn dependency:tree -f cleanup.pom
```

Yields

```
[INFO] |  +- com.google.apis:google-api-services-storage:jar:v1-rev20231202-2.0.0:compile
```

Making the change accordingly, since this mismatch is causing some errors on RC validation: https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1233/checks?check_run_id=19897484522


```
java.lang.NoClassDefFoundError: com/google/api/services/storage/model/Bucket$ObjectRetention
	at com.google.cloud.storage.JsonConversions.<init>(JsonConversions.java:120)
	at com.google.cloud.storage.JsonConversions.<clinit>(JsonConversions.java:89)
	at com.google.cloud.storage.Conversions.json(Conversions.java:33)
	at com.google.cloud.storage.StorageImpl.<clinit>(StorageImpl.java:109)
```
  • Loading branch information
bvolpato committed Dec 22, 2023
1 parent 5b9bbaf commit 1f6d7af
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ class BeamModulePlugin implements Plugin<Project> {
google_api_services_healthcare : "com.google.apis:google-api-services-healthcare:v1-rev20231101-$google_clients_version",
google_api_services_pubsub : "com.google.apis:google-api-services-pubsub:v1-rev20220904-$google_clients_version",
// Keep version consistent with the version in google_cloud_nio, managed by google_cloud_platform_libraries_bom
google_api_services_storage : "com.google.apis:google-api-services-storage:v1-rev20230907-$google_clients_version",
google_api_services_storage : "com.google.apis:google-api-services-storage:v1-rev20231202-$google_clients_version",
google_auth_library_credentials : "com.google.auth:google-auth-library-credentials", // google_cloud_platform_libraries_bom sets version
google_auth_library_oauth2_http : "com.google.auth:google-auth-library-oauth2-http", // google_cloud_platform_libraries_bom sets version
google_cloud_bigquery : "com.google.cloud:google-cloud-bigquery", // google_cloud_platform_libraries_bom sets version
Expand Down

0 comments on commit 1f6d7af

Please sign in to comment.