Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ./gradlew spotlessApply fail groovy check #29264

Merged
merged 1 commit into from Nov 2, 2023
Merged

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Nov 2, 2023

Tested by run ./gradlew spotlessApply

The issue is similar to diffplug/spotless#1572 but as apache/kafka#13205 noted, new version of spotless plugin dropped support of java8. The workaround is needed for current spotless plugin run in gradle 8

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Nov 2, 2023
Copy link
Contributor

@bvolpato bvolpato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified locally

image

@bvolpato
Copy link
Contributor

bvolpato commented Nov 2, 2023

Thanks Yi!

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #29264 (19f27e8) into master (3934117) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #29264      +/-   ##
==========================================
- Coverage   38.33%   38.29%   -0.04%     
==========================================
  Files         688      689       +1     
  Lines      101879   101986     +107     
==========================================
+ Hits        39054    39057       +3     
- Misses      61243    61347     +104     
  Partials     1582     1582              
Flag Coverage Δ
python 29.88% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn Abacn merged commit cf48caf into apache:master Nov 2, 2023
44 checks passed
@Abacn Abacn deleted the fixspotless branch November 2, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants