[Prism] Enable Java validatesRunner tests on Prism #31075
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
damondouglas
changed the title
runners/prism/build.gradle
Outdated
| def jobPortFlag = "job_port" | ||
|
|
||
| // cmdDir is directory conventionally containing Go executables. | ||
| def cmdDir = goRootDir.resolve("cmd") |
There was a problem hiding this comment.
Is it strictly necessary to resolve each directory one step at a time?
That is, instead of just looking for modDir.resolve("go/cmd/prism") directly? Same for the buildTarget chain.
If that doesn't work, a comment explaining why we need to go one step at a time (eg. Gradle makes us do it this way), is more useful than adding comments about what each individual directory is.
Metaphorically: Documenting the forest is important when there are this many trees.
runners/prism/build.gradle
Outdated
| def goRootDir = modDir.resolve("go") | ||
|
|
||
| // jobPortFlag is Prism service's job management service port flag name. | ||
| def jobPortFlag = "job_port" |
There was a problem hiding this comment.
Consider moving this either above or below the directory resolutions, likely just below def jobPort
|
@lostluck This is ready. |
This PR addresses #28187 by creating a new new gradle project
:runners:prismto allow non-Go developers to execute the Prism server. It also modifies the existingrunners/portability/java/build.gradleby adding ajobEndpointproject property to set when invoking:After this test merges, I will update Beam Wiki for Java with a new section on how to run a pipeline using Prism and a new page on our Beam website: https://beam.apache.org/documentation/runners/prism/
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.