Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.12 python hinting errors on MacOS #31246

Merged
merged 2 commits into from
May 10, 2024

Conversation

jrmccluskey
Copy link
Contributor

Fixes a bug with load_fast_and_clear that was deleting an index in an array that was later used as intermediate storage instead of setting the value to None in the interim and fixed the list comprehension in the intrinsic operations test that seems to have been accidentally clobbered in an in-between state from an old form and the new one before merging.

Fixes #31047


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@jrmccluskey
Copy link
Contributor Author

R; @tvalentyn

My M1 mac still doesn't love installing beam on Python 3.12 so I couldn't validate the load_fast_and_clear fix beyond diagnosing it from the tox output you shared, so feel free to port the changes into your environment to double-check

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor

My M1 mac still doesn't love installing beam on Python 3.12 so I couldn't validate the load_fast_and_clear fix beyond diagnosing it from the tox output you shared, so feel free to port the changes into your environment to double-check

Sure. FWIW you might be able to use docker containers as a workaround.

@tvalentyn tvalentyn merged commit 8b5d000 into apache:master May 10, 2024
72 checks passed
@tvalentyn
Copy link
Contributor

Thanks a lot, @jrmccluskey !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support Type Inference on Python 3.12
2 participants