Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests using TFT in Beam ML unit test suite on Python 3.11+ #31288

Merged
merged 3 commits into from
May 15, 2024

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented May 14, 2024

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor Author

tvalentyn commented May 14, 2024

we might have a new and unrelated failure in PreCommit YAML Xlang Direct https://github.com/apache/beam/actions/runs/9087183722/job/24974434368?pr=31288

INFO apache_beam.utils.subprocess_server:subprocess_server.py:213 Exception in thread "main" java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory

INFO     root:external.py:1017 Starting a JAR-based expansion service from JAR /runner/_work/beam/beam/sdks/java/extensions/sql/expansion-service/build/libs/beam-sdks-java-extensions-sql-expansion-service-2.57.0-SNAPSHOT.jar 
INFO     apache_beam.utils.subprocess_server:subprocess_server.py:203 Starting service with ['java' '-jar' '/runner/_work/beam/beam/sdks/java/extensions/sql/expansion-service/build/libs/beam-sdks-java-extensions-sql-expansion-service-2.57.0-SNAPSHOT.jar' '41523' '--filesToStage=/runner/_work/beam/beam/sdks/java/extensions/sql/expansion-service/build/libs/beam-sdks-java-extensions-sql-expansion-service-2.57.0-SNAPSHOT.jar' '--alsoStartLoopbackWorker']
INFO     apache_beam.utils.subprocess_server:subprocess_server.py:213 Exception in thread "main" java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory
INFO     apache_beam.utils.subprocess_server:subprocess_server.py:213 	at org.apache.beam.sdk.expansion.service.ExpansionService.<clinit>(ExpansionService.java:115)
INFO     apache_beam.utils.subprocess_server:subprocess_server.py:213 Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory
INFO     apache_beam.utils.subprocess_server:subprocess_server.py:213 	at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
INFO     apache_beam.utils.subprocess_server:subprocess_server.py:213 	at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
INFO     apache_beam.utils.subprocess_server:subprocess_server.py:213 	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
INFO     apache_beam.utils.subprocess_server:subprocess_server.py:213 	at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
INFO     apache_beam.utils.subprocess_server:subprocess_server.py:213 	... 1 more
ERROR    apache_beam.utils.subprocess_server:subprocess_server.py:174 Started job service with ['java', '-jar', '/runner/_work/beam/beam/sdks/java/extensions/sql/expansion-service/build/libs/beam-sdks-java-extensions-sql-expansion-service-2.57.0-SNAPSHOT.jar', '41523', '--filesToStage=/runner/_work/beam/beam/sdks/java/extensions/sql/expansion-service/build/libs/beam-sdks-java-extensions-sql-expansion-service-2.57.0-SNAPSHOT.jar', '--alsoStartLoopbackWorker']
ERROR    apache_beam.utils.subprocess_server:subprocess_server.py:188 Error bringing up service
Traceback (most recent call last):
  File "/runner/_work/beam/beam/sdks/python/apache_beam/utils/subprocess_server.py", line 175, in start
    raise RuntimeError(
RuntimeError: Service failed to start up with error 1
WARNING  apache_beam.options.pipeline_options:pipeline_options.py:339 Unknown pipeline options received: -v,apache_beam/yaml/integration_tests.py,--deselect,apache_beam/yaml/integration_tests.py::BigqueryTest::test_ReadFromBigQuery_ExternalJavaProvider_0. Ignore if flags are used for internal purposes.
WARNING  apache_beam.options.pipeline_options:pipeline_options.py:364 Discarding flag -v, single dash flags are not allowed.
INFO     root:external.py:1017 Starting a JAR-based expansion service from JAR /runner/_work/beam/beam/sdks/java/extensions/sql/expansion-service/build/libs/beam-sdks-java-extensions-sql-expansion-service-2.57.0-SNAPSHOT.jar 
ERROR    apache_beam.utils.subprocess_server:subprocess_server.py:174 Started job service with ['java', '-jar', '/runner/_work/beam/beam/sdks/java/extensions/sql/expansion-service/build/libs/beam-sdks-java-extensions-sql-expansion-service-2.57.0-SNAPSHOT.jar', '41523', '--filesToStage=/runner/_work/beam/beam/sdks/java/extensions/sql/expansion-service/build/libs/beam-sdks-java-extensions-sql-expansion-service-2.57.0-SNAPSHOT.jar', '--alsoStartLoopbackWorker']
ERROR    apache_beam.utils.subprocess_server:subprocess_server.py:188 Error bringing up service

@tvalentyn tvalentyn changed the title Don't install TFT on Python 3.11+ Skip tests using TFT in Beam ML unit test suite on Python 3.11+ May 14, 2024
@tvalentyn
Copy link
Contributor Author

#31297 for YAML failure.

@shunping
Copy link
Contributor

LGTM!

@tvalentyn tvalentyn merged commit 6de9a60 into apache:master May 15, 2024
82 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: Beam ML unit test suite fails on Python 3.11
2 participants