Don't build sdist or create a venv for tox tasks. #31290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abacn
reviewed
May 14, 2024
| @@ -3061,32 +3061,13 @@ class BeamModulePlugin implements Plugin<Project> { | |||
| } | |||
| project.ext.toxTask = { name, tox_env, posargs='' -> | |||
| project.tasks.register(name) { | |||
| dependsOn setupVirtualenv | |||
| dependsOn ':sdks:python:sdist' | |||
| if (project.hasProperty('useWheelDistribution')) { | |||
There was a problem hiding this comment.
this was added in #28385 and there was some discussion there. Do they still apply?
|
Let's go with rollback for now and clean one thing at a time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not be nessessary to build sdist or bdists for tox tasks, which we currently use to run unit tests only.
This should fix #31289 , if not, we can go with: #31282 or #31283