[Python] Add job name to GCS custom audit info #31300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
shunping
force-pushed
the
custom-audit-python
branch
from
2072aa0
to
f9712de
Compare
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
shunping
changed the title
|
Per #31297, the failure of PreCommit YAML Xlang Direct is expected. |
|
R: @tvalentyn for Python review |
tvalentyn
reviewed
May 15, 2024
tvalentyn
reviewed
May 15, 2024
tvalentyn
approved these changes
May 15, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #31097. It implements feature request #31299 for Python SDK.
We also revamped the code path of setting user-agent (previously introduced in #29765) here and added a test to ensure both headers are set correctly when HTTP requests are sent.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.