Bump grpcio dep version of Python client for supporting ARM #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
eolivelli
reviewed
Aug 18, 2022
| @@ -31,7 +31,7 @@ | |||
| 'six>=1.10.0', | |||
| 'pytz', | |||
| 'futures>=3.2.0;python_version<"3.2"', | |||
| 'grpcio<1.28,>=1.8.2', | |||
| 'grpcio>=1.37', | |||
There was a problem hiding this comment.
My understanding is that we have to put a cap here otherwise auto upgrades may break the client.
IIRC it happened in the past.
I I am mot sure that we have CI that is covering this change.
There was a problem hiding this comment.
Thank you! I threw the change here to see if it breaks anything. To prepare a solid patch I need more time to understand the mechanism and see how to verify the change.
|
Closed for now. |
|
@tisonkun I think we should re-open this, and move to newer Grpc. Otherwise the Pulsar Python client is still stuck with unsupported Grpc version |
|
My bad, this was already addressed in #3875 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference:
In the previous PR #2432 we "release" the version range instead of requiring a minimal version. It seems incorrect and if we'd like to support M1, it seems at least 1.37 is required. Send this patch for testing.