Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experiment] Use Jbang camel k plugin in e2e test #5175

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

[Experiment] Use Jbang camel k plugin in e2e test #5175

wants to merge 11 commits into from

Conversation

gansheer
Copy link
Contributor

Release Note

NONE

squakez
squakez reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! With this approach we can keep kamel test as well while we keep supporting other CLI and be able to start using camel in all the run tests.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Unit test coverage report - coverage decreased from 35.8% to 35.7% (-0.1%)

claudio4j
claudio4j reviewed Feb 21, 2024
View reviewed changes
.github/actions/setup-camel-jbang/install-jbang.sh Outdated Show resolved Hide resolved
e2e/support/test_support.go Outdated
}
} else {
// Use modeline CLI as it's closer to the real usage
c, args, err = cmd.NewKamelWithModelineCommand(ctx, append([]string{"camel", "k"}, args...))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use the environment variable JBANG_NO_VERSION_CHECK=true to avoid jbang to check update.

@gansheer gansheer force-pushed the exp/jbang-installation branch 3 times, most recently from c3ab97d to 72d8f9d Compare February 26, 2024 10:44
@gansheer
Copy link
Contributor Author

gansheer commented Mar 6, 2024

@squakez @oscerd @christophd @claudio4j Could the tests be triggered please 🙏

@gansheer gansheer force-pushed the exp/jbang-installation branch 7 times, most recently from c05455e to a28d669 Compare March 11, 2024 18:46
@claudio4j
Copy link
Contributor

The change to use camel k plugin looks good.
One suggestion, to show some camel-jbang version when dumping e2e error, it would be good to know the jbang and camel version in the dump output.

@gansheer gansheer force-pushed the exp/jbang-installation branch 6 times, most recently from 1c85fe5 to 32474f4 Compare March 19, 2024 14:40
@gansheer gansheer force-pushed the exp/jbang-installation branch 3 times, most recently from f78f771 to d00c4f0 Compare April 3, 2024 13:42
@gansheer gansheer force-pushed the exp/jbang-installation branch 3 times, most recently from e088100 to 0b35ba9 Compare April 23, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez left review comments

@claudio4j claudio4j claudio4j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gansheer @claudio4j @squakez