-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TEST_SKIP_AFTER_FAILURE_COUNT #5475
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure to understand this change request. Consider that when you're running in GH actions, each workflow would execute each test suite individually. For instance, it does make test-common
. So, in such case, this new variable is never took in consideration. The only case where it can make sense here would be in the test-smoke
. However, such a test is only executed at night time before nightly release, and, it only have 4 possible failures, so, we'd really skip almost nothing.
|
Okey, then, we better make the variable scope local to this specific action. Otherwise we can get mislead and think that this is a global scope and would affect all test suite executions. |
How about a |
In surefire, it defaults to 0. Folks set it higher to see e.g. "the first three failures" |
819e3a1
to
bb9f601
Compare
bb9f601
to
0b6ee70
Compare
0b6ee70
to
d9d91f2
Compare
Borrowed from maven surefire - count test failures and skip subsequent tests when
failure count > $TEST_SKIP_AFTER_FAILURE_COUNT
The default is
TEST_SKIP_AFTER_FAILURE_COUNT=3
This can significantly speed up validation of bad PRs