fix(e2e): Tekton test permission failure with olm install command #5505
Conversation
|
@squakez My feeling on the test is that we don't want to confirm so much that the pod can run the |
| @@ -42,7 +42,7 @@ func TestTektonLikeBehavior(t *testing.T) { | |||
| g.Expect(CreateOperatorRoleBinding(t, ctx, ns)).To(Succeed()) | |||
|
|
|||
| g.Eventually(OperatorPod(t, ctx, ns)).Should(BeNil()) | |||
| g.Expect(CreateKamelPod(t, ctx, ns, "tekton-task", "install", "--skip-cluster-setup", "--force")).To(Succeed()) | |||
| g.Expect(CreateKamelPod(t, ctx, ns, "tekton-task", "install", "--skip-cluster-setup", "--olm=false", "--force")).To(Succeed()) | |||
There was a problem hiding this comment.
I think this test should be rewritten from scratch. Here what we're doing is to create a Pod with the operator container and we're asking the Pod to execute kamel install ... just to verify the executable works. I think that the kamel install should not be used as for this purpose. Instead, we should rewrite the test in order to validate something different, for instance kamel run which is what we really expect to use in a Tekton task.
There was a problem hiding this comment.
I see. That explains why I was confused about the purpose of this test. I will merge the current e2e test and write a follow up issue.
Description
When running on an OLM install on OCP the test fails with the following log from the Kamel Pod:
Release Note