CRYPTO-162 openSslCipher support engine. #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garydgregory
requested changes
Jun 14, 2022
There was a problem hiding this comment.
@wenwj0
Thank you for the PR. See the scattered comments.
-1 until this PR has tests to cover all the new code.
| @@ -378,4 +378,7 @@ protected void finalize() throws Throwable { | |||
| clean(); | |||
| } | |||
|
|
|||
| public void engineSetDefaultCiphers(String engineId){ | |||
There was a problem hiding this comment.
Missing Javadoc, fix formatting.
| @@ -60,6 +60,11 @@ public OpenSslCipher(final Properties props, final String transformation) // NOP | |||
| } | |||
|
|
|||
| openSslEngine = OpenSsl.getInstance(transformation); | |||
|
|
|||
| String engineId = props.getProperty(CryptoCipherFactory.CIPHER_ENGINE_KEY); | |||
| if(engineId != null && !engineId.isEmpty()) { | |||
|
This PR is a wrapper over OpenSSL, but If we want to test it, we need to install a specific engine. In my case, i installed kae engine and it worked. But I have no idea that which engine should i choose in the unit test. |
|
You could use the Intel rdrand engine in the unit test. It's always available in OpenSSL for machines of the Ivy Bridge or later generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.