fix: replace & character in project name to avoid error on platform add

apache · Dec 7, 2021 · 5632116 · 5632116
1 parent a1ed1c0
commit 5632116
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/create.js b/lib/create.js
@@ -204,7 +204,7 @@ exports.create = function (project_path, config, options, events) {
     }
 
     var package_name = config.android_packageName() || config.packageName() || 'io.cordova.helloCordova';
-    var project_name = config.name() || 'Hello Cordova';
+    var project_name = config.name() ? config.name().replace(/&/g, '_') : 'Hello Cordova';
 
     var safe_activity_name = config.android_activityName() || options.activityName || 'MainActivity';
     var target_api = check_reqs.get_target(project_path);

diff --git a/spec/unit/create.spec.js b/spec/unit/create.spec.js
@@ -182,6 +182,13 @@ describe('create', function () {
                 });
             });
 
+            it('should replace & character in the ConfigParser-provided project name with underscores', () => {
+                config_mock.name.and.returnValue('& hello &');
+                return create.create(project_path, config_mock, {}, events_mock).then(() => {
+                    expect(create.validateProjectName).toHaveBeenCalledWith('_ hello _');
+                });
+            });
+
             it('should have a default activity name of MainActivity', () => {
                 config_mock.android_activityName.and.returnValue(undefined);
                 return create.create(project_path, config_mock, {}, events_mock).then(() => {