fix: gradle build tools config

apache · Jul 26, 2021 · a33ef91 · a33ef91
1 parent 5e50c1d
commit a33ef91
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/framework/cdv-gradle-config-defaults.json b/framework/cdv-gradle-config-defaults.json
@@ -2,7 +2,7 @@
     "MIN_SDK_VERSION": 22,
     "SDK_VERSION": 30,
     "GRADLE_VERSION": "7.1.1",
-    "BUILD_TOOLS_VERSION": "30.0.3",
+    "MIN_BUILD_TOOLS_VERSION": "30.0.3",
     "AGP_VERSION": "4.2.2",
     "KOTLIN_VERSION": "1.5.20",
     "ANDROIDX_APP_COMPAT_VERSION": "1.3.0",

diff --git a/framework/cordova.gradle b/framework/cordova.gradle
@@ -174,10 +174,20 @@ def doApplyCordovaConfigCustomization() {
         cordovaConfig.ANDROIDX_WEBKIT_VERSION = cdvAndroidXWebKitVersion
     }
 
-    // Ensure the latest installed build tools is selected, with or without defined override
-    cordovaConfig.LATEST_INSTALLED_BUILD_TOOLS = doFindLatestInstalledBuildTools(
-        cordovaConfig.BUILD_TOOLS_VERSION
-    )
+    if (!cordovaConfig.BUILD_TOOLS_VERSION) {
+        cordovaConfig.BUILD_TOOLS_VERSION = doFindLatestInstalledBuildTools(
+            cordovaConfig.MIN_BUILD_TOOLS_VERSION
+        )
+    }
+
+    // Ensure the configured build tools version is at least our declared minimum
+    def buildToolsVersion = new Version(cordovaConfig.BUILD_TOOLS_VERSION)
+    if (buildToolsVersion.isLowerThan(cordovaConfig.MIN_BUILD_TOOLS_VERSION)) {
+        throw new RuntimeException("""
+            Expected Android Build Tools version >= ${cordovaConfig.MIN_BUILD_TOOLS_VERSION},
+            but got Android Build Tools version ${cordovaConfig.BUILD_TOOLS_VERSION}. Please use version ${cordovaConfig.MIN_BUILD_TOOLS_VERSION} or later.
+        """.replaceAll(/\s+/, ' ').trim())
+    }
 }
 
 // Properties exported here are visible to all plugins.

diff --git a/templates/project/app/build.gradle b/templates/project/app/build.gradle
@@ -189,7 +189,7 @@ android {
       abortOnError false
     }
 
-    buildToolsVersion cordovaConfig.LATEST_INSTALLED_BUILD_TOOLS
+    buildToolsVersion cordovaConfig.BUILD_TOOLS_VERSION
 
     // This code exists for Crosswalk and other Native APIs.
     // By default, we multiply the existing version code in the