Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle default values ignored #658

Closed
brodybits opened this issue Feb 10, 2019 · 1 comment
Closed

Gradle default values ignored #658

brodybits opened this issue Feb 10, 2019 · 1 comment

Comments

@brodybits
Copy link
Contributor

From the default values in

cordova-android/bin/templates/project/build.gradle

Lines 43 to 46 in a6f30b6

defaultBuildToolsVersion="28.0.3" //String
defaultMinSdkVersion=19 //Integer - Minimum requirement is Android 4.4
defaultTargetSdkVersion=28 //Integer - We ALWAYS target the latest by default
defaultCompileSdkVersion=28 //Integer - We ALWAYS compile with the latest by default

the following default values seem to be ignored:

  • defaultBuildToolsVersion
  • defaultTargetSdkVersion
  • defaultCompileSdkVersion

The default values were introduced in f790aeb (part of PR #389), where defaultTargetSdkVersion was introduced but never used.

The code that uses defaultBuildToolsVersion and defaultCompileSdkVersion was commented out in c74192d (also part of PR #389).

I discovered this issue through investigation of code related to issue #657 & PR #655.
@brodybits brodybits mentioned this issue Feb 10, 2019
Closed
brodybits pushed a commit to brodybits/cordova-android that referenced this issue Feb 10, 2019
Cleanup build.gradle defaults not used
6c09ea8 
- remove defaultTargetSdkVersion which was never used
- comment out defaultBuildToolsVersion & defaultCompileSdkVersion
  with notes that these values should be defined and used
  someday in the future

Resolves apache#658
Resolves apache#631
This was referenced Feb 10, 2019
Closed
Closed
@brodybits brodybits mentioned this issue Apr 7, 2019
Closed
@erisu
Copy link
Member

erisu commented Jul 21, 2021 •
edited

Closing ticket as the code in question had been removed in Cordova-Android 10. #1212

@erisu erisu closed this as completed Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erisu @brodybits