Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove keystore password prompt #1048

Merged
merged 1 commit into from Apr 13, 2021

Conversation

breautek
Copy link
Contributor

Platforms affected

Android

Motivation and Context

Closes #1021

Description

Removes the gradle keystore password prompt implementation. It was buggy and never worked well for a significant period of time, due to how gradle daemonizes its processes.

This is a breaking change

Intended for the v10 milestone release.

Testing

npm test and manual testing with build.json file.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would hold off on merging this PR until we are ready for a major release.

@breautek breautek added this to In Progress in Release Plan - 10.1.0 via automation Mar 27, 2021
@erisu erisu moved this from In Progress to Reviewer approved in Release Plan - 10.1.0 Apr 13, 2021
@erisu erisu merged commit eefa91b into apache:master Apr 13, 2021
Release Plan - 10.1.0 automation moved this from Reviewer approved to Done Apr 13, 2021
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Keystore Password Prompt is broken
2 participants