refactor!: drop support for android SDK tool
#1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
requested review from
purplecabbage,
dpogue,
erisu,
dpa99c and
breautek
raphinesse
force-pushed
the
drop-android-cli-tool-support
branch
from
25c4741
to
605c482
Compare
breautek
approved these changes
Oct 6, 2020
erisu
approved these changes
Oct 6, 2020
|
Thanks for the review everyone! Since this is a breaking change for next major, how do we want to continue with this PR?
Side note: I will probably need some integration branch for multiple breaking changes anyway |
This might be a good idea for testing PRs against the collection of other breaking changes to be released. |
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Oct 19, 2020
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Oct 22, 2020
`emulator.list_images` now always uses the `avdmanager` binary.
`android_sdk.list_targets` now always uses the `avdmanager` binary.
raphinesse
force-pushed
the
drop-android-cli-tool-support
branch
from
605c482
to
caf8a3e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
- Coverage 71.41% 70.50% -0.91%
==========================================
Files 20 20
Lines 1770 1719 -51
==========================================
- Hits 1264 1212 -52
- Misses 506 507 +1
Continue to review full report at Codecov.
|
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
* refactor(emulator)!: remove support for legacy `android` binary `emulator.list_images` now always uses the `avdmanager` binary. * refactor(android_sdk)!: remove support for legacy `android` binary `android_sdk.list_targets` now always uses the `avdmanager` binary. * refactor(check_reqs)!: do not look for legacy `android` binary * refactor: replace installation instructions involving `android` binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We have multiple places where we support both the legacy
androidSDK tool as well asavdmanagerandsdkmanagerfrom current SDK tools. This makes code more complicated and maintenance more difficult.This PR removes the support for the
androidCLI tool from our code base. After this change, to usecordova-androidusers will need either:Closes #595 #741
Description
emulator.list_imagesnow always uses theavdmanagerbinary.android_sdk.list_targetsnow always uses theavdmanagerbinary.check_reqs.check_androiddoes not consider legacyandroidbinary for SDK detection anymoreandroidbinary anymoreThere are multiple opportunities for further simplification after the code removal in this PR. I already have seized some of these in a local branch but I would prefer to open new PRs for these after this is merged.
Testing
node -e "require('./bin/templates/cordova/lib/emulator').list_images().then(console.log)"node -e "require('./bin/templates/cordova/lib/android_sdk').list_targets().then(console.log)"node -e "require('./bin/templates/cordova/lib/check_reqs').check_android().then(console.log)"