Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove deprecated AppCache settings #1141

Merged
merged 1 commit into from Apr 13, 2021

Conversation

NiklasMerz
Copy link
Member

@NiklasMerz NiklasMerz commented Dec 3, 2020

Platforms affected

Android

Motivation and Context

The App Cache API will soon be removed: https://web.dev/appcache-removal/

The app cache methods for WebSettings are another thing that get deprecated for API level 30: https://developer.android.com/reference/android/webkit/WebSettings#setAppCacheEnabled(boolean)

Description

The app cache web API is considered deprecated and will get removed from Chrome/the Android webview around April 2021. Service workers are considered an alternative.

Testing

Unit tests

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

The App Cache API will soon be removed
@NiklasMerz NiklasMerz added this to the 10.0.0 milestone Dec 3, 2020
@erisu erisu changed the title remove app cache settings breaking: remove deprecated AppCache settings Mar 26, 2021
@breautek breautek added this to In Progress in Release Plan - 10.1.0 via automation Mar 27, 2021
@erisu erisu moved this from In Progress to Reviewer approved in Release Plan - 10.1.0 Apr 13, 2021
@erisu erisu merged commit 2a92c77 into apache:master Apr 13, 2021
Release Plan - 10.1.0 automation moved this from Reviewer approved to Done Apr 13, 2021
@NiklasMerz NiklasMerz deleted the appcache branch April 13, 2021 10:22
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants