Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: overload PluginEntry constructor to set onload property #1166

Merged
merged 2 commits into from
Apr 18, 2021
Merged

feat: overload PluginEntry constructor to set onload property #1166

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2a0f06
(Android) Add plugin entry constructor exposing onLoad
jblejder Feb 18, 2021
0a2a590
chore: added JavaDoc comments to overload PluginEntry methods
erisu Apr 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions framework/src/org/apache/cordova/PluginEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ public PluginEntry(String service, CordovaPlugin plugin) {
this(service, plugin.getClass().getName(), true, plugin);
}

public PluginEntry(String service, CordovaPlugin plugin, boolean onload) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a JavaDoc comment for this overload? Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jblejder would you be able to add in the JavaDoc comment?

You can use the below public PluginEntry overloaded method's comment block as an example for your overloaded method.

After this PR is updated, I can merge it in for next release.

this(service, plugin.getClass().getName(), onload, plugin);
}

/**
* @param service The name of the service
* @param pluginClass The plugin class name
Expand Down