Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade jfrog gradle-bintray-plugin@1.8.5 #1201

Merged
merged 3 commits into from Apr 13, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 10, 2021

Motivation, Context & Description

Even though this plugin maybe removed in the 10.0.0 release, the goal of this PR is to reintroduce the original contribution as much as possible.

PR is based off PR #1200 and should be rebased after merged.

@erisu erisu added this to the 10.0.0 milestone Apr 10, 2021
@erisu erisu requested a review from breautek April 10, 2021 04:11
@codecov-io
Copy link

Codecov Report

Merging #1201 (5957091) into master (9c165cb) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1201   +/-   ##
=======================================
  Coverage   72.81%   72.81%           
=======================================
  Files          21       21           
  Lines        1747     1747           
=======================================
  Hits         1272     1272           
  Misses        475      475           
Impacted Files Coverage Δ
...n/templates/cordova/lib/builders/ProjectBuilder.js 74.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c165cb...5957091. Read the comment docs.

mosabab and others added 3 commits April 13, 2021 17:52
…frog.bintray.gradle 1.8.5 (apache#1079)

* Update ProjectBuilder.js
* Update build.gradle
* Update wrapper.gradle
* original contribution PR: apache#1079

Co-authored-by: Mosab A <47486787+mosabab@users.noreply.github.com>
@erisu erisu force-pushed the breaking/upgrade-jfrog-bintry branch from 5957091 to a95945b Compare April 13, 2021 08:53
@erisu erisu merged commit cab9840 into apache:master Apr 13, 2021
@erisu erisu deleted the breaking/upgrade-jfrog-bintry branch April 13, 2021 09:10
@erisu erisu added this to In Progress in Release Plan - 10.1.0 via automation Apr 13, 2021
@erisu erisu moved this from In Progress to Done in Release Plan - 10.1.0 Apr 13, 2021
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
* breaking: upgrade jfrog gradle-bintray-plugin@1.8.5
* original contribution PR: apache#1079

Co-authored-by: Mosab A <47486787+mosabab@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants