test(AndroidManifest): update theme to Theme.AppCompat.NoActionBar #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisu
changed the title
erisu
changed the title
spec/unit/AndroidManifest.spec.js
Outdated
| @@ -40,7 +40,7 @@ describe('AndroidManifest', () => { | |||
| android:supportsRtl="true" android:debuggable="true"> | |||
| <activity android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale" | |||
| android:label="@string/activity_name" android:launchMode="${ACTIVITY_LAUNCH_MODE}" | |||
| android:name="${ACTIVITY_NAME}" android:theme="@android:style/Theme.DeviceDefault.NoActionBar" | |||
| android:name="${ACTIVITY_NAME}" android:theme="@android:style/Theme.AppCompat.NoActionBar" | |||
There was a problem hiding this comment.
The android: before style/Theme was also removed
Codecov Report
@@ Coverage Diff @@
## master #1207 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 21 21
Lines 1692 1692
=======================================
Hits 1218 1218
Misses 474 474 Continue to review full report at Codecov.
|
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Update
AndroidManifest.spec.jsbased on comment from this PR: #1052 (review)Description
Changed
Theme.DeviceDefault.NoActionBartoTheme.AppCompat.NoActionBarto match changes from PR #1052